[PATCH] D61372: [coroutines] Fix spills of static array allocas

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.

Hi, I added a few inline comments, mostly just nits on style.



================
Comment at: lib/Transforms/Coroutines/CoroFrame.cpp:405
 
+    uint64_t count = 1;
     Type *Ty = nullptr;
----------------
count -> Count


================
Comment at: lib/Transforms/Coroutines/CoroFrame.cpp:507
+  auto GetFramePointer = [&](uint32_t Index, Value *Orig) -> Value * {
+    SmallVector<Value *, 3> indices = {
+        ConstantInt::get(Type::getInt32Ty(C), 0),
----------------
indices -> Indices


================
Comment at: lib/Transforms/Coroutines/CoroFrame.cpp:514
+      if (auto *CI = dyn_cast<ConstantInt>(AI->getArraySize())) {
+        auto count = CI->getValue().getZExtValue();
+        if (count > 1) {
----------------
count -> Count


================
Comment at: test/Transforms/Coroutines/coro-frame-arrayalloca.ll:3
+; RUN: opt < %s -coro-split -S | FileCheck %s
+; RUN: opt < %s -coro-split -S | FileCheck %s
+
----------------
Is this second RUN redundant?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61372/new/

https://reviews.llvm.org/D61372