[PATCH] D61421: [Object] Change getSectionName() to use Expected<StringRef>

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 2 03:14:14 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM. It might be worth a TODO/FIXME next to that consumeError saying we should propagate it (assuming that we should).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61421/new/

https://reviews.llvm.org/D61421





More information about the llvm-commits mailing list