[PATCH] D61421: [Object] Change getSectionName() to use Expected<StringRef>
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 2 01:41:18 PDT 2019
jhenderson added a comment.
Looks good, apart from one comment.
================
Comment at: llvm/tools/llvm-readobj/COFFDumper.cpp:1545
COFF::IMAGE_FILE_MACHINE_ARM64);
- Decoder.dumpProcedureData(*Obj);
+ (void)!Decoder.dumpProcedureData(*Obj);
break;
----------------
I'm not sure this is the right way to throw away an Error. Assuming for a moment that we don't want to report this error here (I'm guessing we probably should at some point), you should use something like `consumeError`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61421/new/
https://reviews.llvm.org/D61421
More information about the llvm-commits
mailing list