[PATCH] D60760: Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 2 01:32:45 PDT 2019


lebedev.ri added a comment.

In D60760#1487387 <https://reviews.llvm.org/D60760#1487387>, @sberg wrote:

> In D60760#1487342 <https://reviews.llvm.org/D60760#1487342>, @lebedev.ri wrote:
>
> > Did this get reviewed?
>
>
> I didn't get any responses at all, so decided to push it anyway.


That is not really how reviews work in LLVM.
Either it's a NFC / eligible for post-commit review, and can just be committed, or not.
E.g., is this missing test coverage?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60760/new/

https://reviews.llvm.org/D60760





More information about the llvm-commits mailing list