[PATCH] D61387: [CMake][benchmark] Cache result of CXXFeatureCheck

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 2 01:00:24 PDT 2019


lebedev.ri added a comment.

In D61387#1487036 <https://reviews.llvm.org/D61387#1487036>, @beanz wrote:

> That kinda makes it worse. We don't duplicate gtest in all the tools that use it, why are we duplicating this library?


Testsuite can be built without llvm; llvm can be built without testsuite; llvm can be built without libc++ - so you already have two copies - in llvm and testsuite
Likely libc++ also wants to be buildable standalone (including benchmarks)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61387/new/

https://reviews.llvm.org/D61387





More information about the llvm-commits mailing list