[PATCH] D60878: [Object][XCOFF] Add an XCOFF dumper for llvm-readobj

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/xcoff-basic.test:1
+# RUN: llvm-readobj --file-header %p/Inputs/xcoff-basic.o | \
+# RUN: FileCheck --check-prefix=FILEHEADER %s
----------------
`// REQUIRES: powerpc-registered-target` ?


`arc patch D60878` gives me empty `xcoff-basic-neg-time.o`. I can't verify their architectures.


================
Comment at: llvm/tools/llvm-readobj/XCOFFDumper.cpp:44
+void XCOFFDumper::printFileHeaders() {
+
+  DictScope DS(W, "FileHeader");
----------------
Delete the empty line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60878/new/

https://reviews.llvm.org/D60878