[PATCH] D61411: [SelectionDAG] Expand ADD/SUBCARRY

[Leonard Chan via Phabricator via llvm-commits]

leonardchan added a comment.

In D61411#1487156 <https://reviews.llvm.org/D61411#1487156>, @efriedma wrote:

> LGTM
>
> Please run some basic sanity tests before you merge to make sure this works correctly at runtime.  The code looks right, but I don't really trust that. :)  If you want to test something simpler than smul.fix, might make sense to just temporarily hack legalization for addition to use this codepath, or something like that, so you can easily understand what you're actually testing.


Good thing I checked! I did as you suggested by forcing 32bit x86 to take this path and found a bunch of type mismatches. After fixing that, everything looks good for expected results. Will submit tomorrow morning if there aren't any more comments then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61411/new/

https://reviews.llvm.org/D61411