[PATCH] D55864: [elfabi] Write program headers, .dynamic, .dynstr, and .shstrtab

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich updated this revision to Diff 197695.
jakehehrlich added a comment.

Ok we're getting closer

1. Formatted everything
2. Added suggestions
3. Program headers are now added
4. All tests now pass
5. In theory (but almost certainly not in reality) this should represent a minimal viable product with the exception of support for Alignment

What remains:

1. Add support for Alignment
2. Add tests for dynamic symbol table, def size, and tls size
3. Split up into more manageable chunks so that humans can review this. Any review now is still appreciated of course.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55864/new/

https://reviews.llvm.org/D55864

Files:
  llvm/include/llvm/TextAPI/ELF/ELFStub.h
  llvm/llvm/test/tools/llvm-elfabi/binary-write-neededlibs.test
  llvm/llvm/test/tools/llvm-elfabi/binary-write-pheaders.test
  llvm/llvm/test/tools/llvm-elfabi/binary-write-sheaders.test
  llvm/llvm/test/tools/llvm-elfabi/binary-write-soname.test
  llvm/test/tools/llvm-elfabi/binary-write-neededlibs.test
  llvm/test/tools/llvm-elfabi/binary-write-pheaders.test
  llvm/test/tools/llvm-elfabi/binary-write-sheaders.test
  llvm/test/tools/llvm-elfabi/binary-write-soname.test
  llvm/test/tools/llvm-elfabi/invalid-bin-target.test
  llvm/test/tools/llvm-elfabi/missing-bin-target.test
  llvm/test/tools/llvm-elfabi/write-elf32be-ehdr.test
  llvm/test/tools/llvm-elfabi/write-elf32le-ehdr.test
  llvm/test/tools/llvm-elfabi/write-elf64be-ehdr.test
  llvm/test/tools/llvm-elfabi/write-elf64le-ehdr.test
  llvm/tools/llvm-elfabi/ELFObjHandler.cpp
  llvm/tools/llvm-elfabi/ELFObjHandler.h
  llvm/tools/llvm-elfabi/llvm-elfabi.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55864.197695.patch
Type: text/x-patch
Size: 45026 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190502/64bccc12/attachment-0001.bin>