[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

Wed May 1 16:49:13 PDT 2019

dyung added a comment.

In D61187#1486249 <https://reviews.llvm.org/D61187#1486249>, @probinson wrote:

> FYI, we had to disable clangd entirely after this patch, getting a weird problem with lit that we haven't figured out yet.
>  In case anybody else has seen something like this, and knows what's going on, please let us know.
>
>     Running all regression tests
>     llvm-lit.py: C:/j/w/opensource/opensource_to_sce_merge__2/o/llvm\utils\lit\lit\llvm\config.py:336: fatal: couldn't find 'clang' program, try setting CLANG in your environment
>   C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 2. [C:\j\w\opensource\opensource_to_sce_merge__2\build\check-all.vcxproj]
>

To expand on this, I attempted to do a clean upstream build/test with a recent revision (r359727 if it matters), and I am seeing this error when attempting to use Visual Studio to build/test on Windows. Due to the nature of the problem, I suspect anyone using XCode to build/test would also run into a similar problem.

In my build, if I put a breakpoint in the script right before it emits the error and dump the path, the problem is pretty obvious in the first entry:

'c:\\src\\upstream\\359727-win32-release\\%(build_mode)s\\bin

This appears to be a cmake related problem because the "%(build_mode)s" should have been replaced by "Release" in this case. These kinds of problems often only manifest when building using Visual Studio or XCode since the build configuration isn't set until build time.

Both the clangd and clangd unit tests seem to have this problem. The problem is not eliminated until I remove both sets of tests from the command line used to run the tests. Unfortunately I don't really have the expertise to fix these problems, but maybe someone else does. But until it is fixed, testing of clangd with either Visual Studio or XCode is likely broken.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61187/new/

https://reviews.llvm.org/D61187