[PATCH] D61411: [SelectionDAG] Expand ADD/SUBCARRY

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:3300
+    SDValue Overflow2 = IsAdd ? DAG.getSetCC(dl, VT, Sum2, Zero, ISD::SETEQ)
+                              : DAG.getSetCC(dl, VT, Sum, Zero, ISD::SETEQ);
+
----------------
Are you sure this is right?  The comment is correct, but there's only an overflow if the carry is set and the result is zero.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61411/new/

https://reviews.llvm.org/D61411