[llvm] r359739 - Revert r359717, "Make check-clang depend on the clang-check binary always"

Nico Weber via llvm-commits llvm-commits at lists.llvm.org
Wed May 1 16:32:38 PDT 2019


Author: nico
Date: Wed May  1 16:32:38 2019
New Revision: 359739

URL: http://llvm.org/viewvc/llvm-project?rev=359739&view=rev
Log:
Revert r359717, "Make check-clang depend on the clang-check binary always"

The Tooling tests do have a lit.local.cfg with

    if not config.root.clang_staticanalyzer:
        config.unsupported = True

so what's wrong isn't the missing dep, but that lit prints a warning for
the binary missing. This will need a different kind of fix.

Modified:
    llvm/trunk/utils/gn/secondary/clang/test/BUILD.gn

Modified: llvm/trunk/utils/gn/secondary/clang/test/BUILD.gn
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/secondary/clang/test/BUILD.gn?rev=359739&r1=359738&r2=359739&view=diff
==============================================================================
--- llvm/trunk/utils/gn/secondary/clang/test/BUILD.gn (original)
+++ llvm/trunk/utils/gn/secondary/clang/test/BUILD.gn Wed May  1 16:32:38 2019
@@ -108,7 +108,6 @@ group("test") {
     ":lit_unit_site_cfg",
     "//clang/lib/Headers",
     "//clang/tools/c-index-test",
-    "//clang/tools/clang-check",
     "//clang/tools/clang-diff",
     "//clang/tools/clang-format",
     "//clang/tools/clang-import-test",
@@ -148,6 +147,7 @@ group("test") {
   }
   if (clang_enable_static_analyzer) {
     deps += [
+      "//clang/tools/clang-check",
       "//clang/tools/clang-extdef-mapping",
     ]
   }




More information about the llvm-commits mailing list