[PATCH] D61405: [PGO][CHR] A bug fix.
Hiroshi Yamauchi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 1 15:18:45 PDT 2019
yamauchi marked an inline comment as done.
yamauchi added inline comments.
================
Comment at: lib/Transforms/Instrumentation/ControlHeightReduction.cpp:1444
return;
if (HoistedSet.count(I))
// Already hoisted, return.
----------------
yamauchi wrote:
> davidxl wrote:
> > why is this check not kicking in?
> This check is to avoid hoisting the same instruction more than once. So, it won't detect this case.
Typo: insert *per scope* in above sentence.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61405/new/
https://reviews.llvm.org/D61405
More information about the llvm-commits
mailing list