[compiler-rt] r359731 - [tsan] Fix and re-enable user_malloc.cc test
Vitaly Buka via llvm-commits
llvm-commits at lists.llvm.org
Wed May 1 14:53:39 PDT 2019
Author: vitalybuka
Date: Wed May 1 14:53:39 2019
New Revision: 359731
URL: http://llvm.org/viewvc/llvm-project?rev=359731&view=rev
Log:
[tsan] Fix and re-enable user_malloc.cc test
Summary: no_sanitize_thread is not enough as it still puts some tsan instrumentation
Reviewers: eugenis
Subscribers: kubamracek, #sanitizers, llvm-commits
Tags: #sanitizers, #llvm
Differential Revision: https://reviews.llvm.org/D61393
Modified:
compiler-rt/trunk/test/tsan/Linux/user_malloc.cc
Modified: compiler-rt/trunk/test/tsan/Linux/user_malloc.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/Linux/user_malloc.cc?rev=359731&r1=359730&r2=359731&view=diff
==============================================================================
--- compiler-rt/trunk/test/tsan/Linux/user_malloc.cc (original)
+++ compiler-rt/trunk/test/tsan/Linux/user_malloc.cc Wed May 1 14:53:39 2019
@@ -1,18 +1,14 @@
-// RUN: %clangxx_tsan -O1 %s -o %t && %run %t 2>&1 | FileCheck %s
-
-// UNSUPPORTED: powerpc64le
-
-// FIXME: Remove the test or find how to fix this.
-// On some distributions, probably with newer glibc, tsan initialization calls
-// dlsym which then calls malloc and crashes because of tsan is not initialized.
-// UNSUPPORTED: linux
+// RUN: %clangxx_tsan -c -O1 -fno-sanitize=thread %s -o %t.o
+// RUN: %clangxx_tsan -O1 %s %t.o -o %t && %run %t 2>&1 | FileCheck %s
#include <stdio.h>
+#include <stdlib.h>
+
+#if !__has_feature(thread_sanitizer)
// Defined by tsan.
extern "C" void *__interceptor_malloc(unsigned long size);
extern "C" void __interceptor_free(void *p);
-
extern "C" void *malloc(unsigned long size) {
static int first = 0;
if (__sync_lock_test_and_set(&first, 1) == 0)
@@ -24,12 +20,16 @@ extern "C" void free(void *p) {
__interceptor_free(p);
}
+#else
+
int main() {
volatile char *p = (char*)malloc(10);
p[0] = 0;
free((void*)p);
}
+#endif
+
// CHECK: user malloc
// CHECK-NOT: ThreadSanitizer
More information about the llvm-commits
mailing list