[PATCH] D61387: [CMake][benchmark] Cache result of CXXFeatureCheck

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri requested changes to this revision.
lebedev.ri added a comment.
This revision now requires changes to proceed.

In D61387#1486871 <https://reviews.llvm.org/D61387#1486871>, @beanz wrote:

> @lebedev.ri I actually disagree with prefixing capabilities check variables. If other projects are checking the same thing you want them to use the same variable so that they don't all check the same thing over and over again.


Or they happen to just use the same name but use it for different things.

> Also, why is this duplicated between libcxx, test-suite and llvm? There is functionality in the libcxx build that requires the LLVM CMake modules (like building the tests), so it seems like a better solution would be having this module be a llvm CMake module that is shared across the other projects.

I'm not sure i follow.
There are three copies of the entire `benchmark` library - one here in llvm, one in libc++ and one in test-suite.
This isn't just about this cmake file (which is part of the benchmark library)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61387/new/

https://reviews.llvm.org/D61387