[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 1 14:16:48 PDT 2019
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
The only remaining change I find questionable is the R600 backend change, but on the whole I think it's fine and you don't need to wait for more review. Better to fix the warnings and people with concerns can repaint the bikeshed as they like.
================
Comment at: llvm/trunk/unittests/IR/ConstantRangeTest.cpp:462
+ // Silence warning: variable 'HaveInterrupt3' set but not used
+ (void)HaveInterrupt3;
----------------
I don't think a comment here is necessary, casting something to avoid before an assert is a pretty standard idiom for "suppress -Wunused-variable".
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61046/new/
https://reviews.llvm.org/D61046
More information about the llvm-commits
mailing list