[PATCH] D59119: [SelectionDAG] Check legality for ADDCARRY in expandMUL_LOHI
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 1 13:51:07 PDT 2019
efriedma added a comment.
If this is fixing a SPARC issue, please add an appropriate testcase for the SPARC backend.
If iN ADDCARRY isn't legal, but iN is legal, it makes sense to handle that in SelectionDAGLegalize::ExpandNode, yes. I thought we had that code already, but I guess not. We should eventually implement ADDCARRY support for SPARC, but the code in SelectionDAGLegalize::ExpandNode will be useful for other targets which don't have an ADDCARRY-like instruction, like RISCV.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59119/new/
https://reviews.llvm.org/D59119
More information about the llvm-commits
mailing list