[PATCH] D61307: [InstCombine] Add new combine to sub folding

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM too with Roman's test suggestions in place.

Another couple of minor improvements for those:

1. I prefer to give the tests slightly meaningful names and/or copy the code comment to help explain the transform.
2. It's nice to have a test with vector type, so we know those work/won't regress too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61307/new/

https://reviews.llvm.org/D61307