[llvm] r359717 - Make check-clang depend on the clang-check binary always

Nico Weber via llvm-commits llvm-commits at lists.llvm.org
Wed May 1 12:34:01 PDT 2019


Author: nico
Date: Wed May  1 12:34:00 2019
New Revision: 359717

URL: http://llvm.org/viewvc/llvm-project?rev=359717&view=rev
Log:
Make check-clang depend on the clang-check binary always

check-clang (the target that runs all clang tests) used to
only depend on clang-check (a binary like clang-tidy,
clang-refactor, etc) if the static analyzer is enabled.
However, several lit tests call clang-check unconditionally,
so always depend on it.

Fixes a "could not find clang-check" lit warning in clean builds with
the static analyzer disabled.

Also sort the deps in the CMake file and put just one dep on each line.

Differential Revision: https://reviews.llvm.org/D61324

Modified:
    llvm/trunk/utils/gn/secondary/clang/test/BUILD.gn

Modified: llvm/trunk/utils/gn/secondary/clang/test/BUILD.gn
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/secondary/clang/test/BUILD.gn?rev=359717&r1=359716&r2=359717&view=diff
==============================================================================
--- llvm/trunk/utils/gn/secondary/clang/test/BUILD.gn (original)
+++ llvm/trunk/utils/gn/secondary/clang/test/BUILD.gn Wed May  1 12:34:00 2019
@@ -108,6 +108,7 @@ group("test") {
     ":lit_unit_site_cfg",
     "//clang/lib/Headers",
     "//clang/tools/c-index-test",
+    "//clang/tools/clang-check",
     "//clang/tools/clang-diff",
     "//clang/tools/clang-format",
     "//clang/tools/clang-import-test",
@@ -147,7 +148,6 @@ group("test") {
   }
   if (clang_enable_static_analyzer) {
     deps += [
-      "//clang/tools/clang-check",
       "//clang/tools/clang-extdef-mapping",
     ]
   }




More information about the llvm-commits mailing list