[PATCH] D61390: [CodeGen] Add lround/llround builtins

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 1 11:40:01 PDT 2019


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringBase.cpp:717
+  // More library functions default to expand.
+  setOperationAction(ISD::LROUND,  MVT::i32, Expand);
+  setOperationAction(ISD::LROUND,  MVT::i64, Expand);
----------------
I wonder if it wouldn't make more sense to index the operation action table by the FP type rather than the result type.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61390/new/

https://reviews.llvm.org/D61390





More information about the llvm-commits mailing list