[PATCH] D61196: Minor tweaks to PDB docs

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 1 11:20:59 PDT 2019


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm with some suggestions



================
Comment at: llvm/docs/PDB/TpiStream.rst:311
 
-log(n) random access is provided by way of the Type Index Offsets array (if present)
-described previously.
\ No newline at end of file
+log(n) access is provided by way of the Type Index Offsets array (if present)
+described previously.
----------------
nit: I think `O(log(n))` access would be clearer.


================
Comment at: llvm/docs/PDB/index.rst:66
+arbitrary data, and these streams are divided into blocks which may not
+necessarily be contiguously laid out within the file (aka fragmented).
+Additionally, the MSF contains a stream directory (aka MFT) which describes how
----------------
nit: "... not necessarily be contiguously laid out within the MSF container file." I think that's clearer, "aka fragmented" isn't necessary.


================
Comment at: llvm/include/llvm/DebugInfo/PDB/Native/RawTypes.h:344
 };
-
 static_assert(sizeof(SrcHeaderBlockEntry) == 40, "Incorrect struct size!");
----------------
Revert whitespace-only change to a file?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61196/new/

https://reviews.llvm.org/D61196





More information about the llvm-commits mailing list