[PATCH] D61358: [Sanitizer] Reland "Cleanup INTERCEPT_FUNCTION macro"

Wed May 1 10:51:29 PDT 2019

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm, thanks

================
Comment at: compiler-rt/lib/asan/asan_interceptors.h:125
   do {                                                                   \
-    if ((!INTERCEPT_FUNCTION(name) || !REAL(name)))                      \
       VReport(1, "AddressSanitizer: failed to intercept '" #name "'\n"); \
----------------
This could be a change in behavior, but I think I'm OK with it. I see that the check is redundant on the Linux side, but it's not immediately clear that the Windows side interception maintains the invariant that it returns false if it can't fill in REAL(name). But, ultimately this condition only affects logging here, and it would help uncover bugs in the Windows side code, so I think this is a good change.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61358/new/

https://reviews.llvm.org/D61358