[PATCH] D61263: [X86][SSE] Fold scalar horizontal add/sub for non-0/1 element extractions

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 1 09:22:26 PDT 2019


RKSimon marked an inline comment as done.
RKSimon added inline comments.


================
Comment at: test/CodeGen/X86/haddsub.ll:1012
 ; AVX-NEXT:    vpermilps {{.*#+}} xmm0 = xmm0[3,1,2,3]
 ; AVX-NEXT:    vaddss %xmm0, %xmm1, %xmm0
 ; AVX-NEXT:    vzeroupper
----------------
RKSimon wrote:
> We still miss folding to extractf128+hadd+permilps - but the cost-benefit isn't great.
FYI - I have a follow up mini-patch that will fix this.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61263/new/

https://reviews.llvm.org/D61263





More information about the llvm-commits mailing list