[PATCH] D61226: [AArch64] Add an option to get the TLS pointer from software

[Tim Northover via Phabricator via llvm-commits]

t.p.northover added inline comments.


================
Comment at: lib/Target/AArch64/AArch64ExpandPseudoInsts.cpp:525
+            .addExternalSymbol("__aarch64_read_tp")
+            .addReg(DstReg, RegState::Dead)
+            .cloneMemRefs(MI);
----------------
efriedma wrote:
> Is this addReg necessary?  The definition of X0 is an implicit definition, so it should be copied by transferImpOps, unless I'm missing something.
> 
> RegState::Dead doesn't make any sense.
It's also non-implicit (which I'm surprised MCInstrDesc doesn't complain about), and a use rather than a def.


================
Comment at: lib/Target/AArch64/AArch64Subtarget.h:379
 
+  bool IsReadTPSoft() const { return ReadTpSoft; }
+
----------------
Functions start lower case.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61226/new/

https://reviews.llvm.org/D61226