[llvm] r359667 - [X86] SimplifyDemandedVectorEltsForTargetNode - pull out vector halving code. NFCI.

[Simon Pilgrim via llvm-commits]

Author: rksimon
Date: Wed May  1 03:38:10 2019
New Revision: 359667

URL: http://llvm.org/viewvc/llvm-project?rev=359667&view=rev
Log:
[X86] SimplifyDemandedVectorEltsForTargetNode - pull out vector halving code. NFCI.

Pull out the HADD/HSUB code to halve vector widths if the upper half isn't used - prep work to adding support for other opcodes.

Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=359667&r1=359666&r2=359667&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Wed May  1 03:38:10 2019
@@ -33398,14 +33398,18 @@ bool X86TargetLowering::SimplifyDemanded
       return true;
     break;
   }
-  case X86ISD::HADD:
-  case X86ISD::HSUB:
-  case X86ISD::FHADD:
-  case X86ISD::FHSUB: {
-    // 256-bit horizontal ops are two 128-bit ops glued together. If we do not
-    // demand any of the high elements, then narrow the h-op to 128-bits:
-    // (hop ymm0, ymm1) --> insert undef, (hop xmm0, xmm1), 0
-    if (VT.is256BitVector() && DemandedElts.lshr(NumElts / 2) == 0) {
+  }
+
+  // For 256-bit ops that are two 128-bit ops glued together, if we do not
+  // demand any of the high elements, then narrow the op to 128-bits:
+  // (op ymm0, ymm1) --> insert undef, (op xmm0, xmm1), 0
+  // TODO: Handle 512-bit -> 128/256-bit ops as well.
+  if (VT.is256BitVector() && DemandedElts.lshr(NumElts / 2) == 0) {
+    switch (Opc) {
+    case X86ISD::HADD:
+    case X86ISD::HSUB:
+    case X86ISD::FHADD:
+    case X86ISD::FHSUB: {
       SDLoc DL(Op);
       SDValue Ext0 = extract128BitVector(Op.getOperand(0), 0, TLO.DAG, DL);
       SDValue Ext1 = extract128BitVector(Op.getOperand(1), 0, TLO.DAG, DL);
@@ -33414,8 +33418,7 @@ bool X86TargetLowering::SimplifyDemanded
       SDValue Insert = insert128BitVector(UndefVec, Hop, 0, TLO.DAG, DL);
       return TLO.CombineTo(Op, Insert);
     }
-    break;
-  }
+    }
   }
 
   // Simplify target shuffles.