[PATCH] D61322: [yaml2obj] - Report when unknown section is referenced from program header declaration block.

Wed May 1 02:49:03 PDT 2019

grimar marked an inline comment as done.
grimar added inline comments.

================
Comment at: test/tools/llvm-objcopy/ELF/no-build-id.test:13
 Sections:
-  - Name:            .note.foo
+  - Name:            .note.gnu.foo
     Type:            SHT_NOTE
----------------
jhenderson wrote:
> If you want to leave it as is, then fine, but I'd actually prefer the section name be changed to .note.foo in both cases, not .note.gnu.foo, since the "gnu" bit implies something specific to do with GNU which isn't the case.
I changed the name as you suggested before the commit.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61322/new/

https://reviews.llvm.org/D61322