[PATCH] D61312: [llvm-objdump] - Print relocation record in a GNU format.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: include/llvm/Object/ObjectFile.h:426
 inline bool SectionRef::operator==(const SectionRef &Other) const {
+  if (OwningObject != Other.OwningObject)
+    return false;
----------------
I'm not sure I understand what the purpose of this check and the similar ones below is? In what cases could SectionPimpl ever equal Other.SectionPimpl and need disambugiating on the OwningObject?


================
Comment at: test/tools/llvm-objdump/relocations-elf.test:78
+# RUN: not llvm-objdump --reloc %t2 2>&1 | FileCheck %s --check-prefix=ERR
+# ERR: LLVM ERROR: Invalid data was encountered while parsing the file
+
----------------
This is not a nice error. Can anything be done easily to improve it?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61312/new/

https://reviews.llvm.org/D61312