[PATCH] D61322: [yaml2obj] - Report when unknown section is referenced from program header declaration block.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 1 01:37:17 PDT 2019


jhenderson added inline comments.


================
Comment at: test/tools/llvm-objcopy/ELF/no-build-id.test:13
 Sections:
-  - Name:            .note.foo
+  - Name:            .note.gnu.foo
     Type:            SHT_NOTE
----------------
If you want to leave it as is, then fine, but I'd actually prefer the section name be changed to .note.foo in both cases, not .note.gnu.foo, since the "gnu" bit implies something specific to do with GNU which isn't the case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61322/new/

https://reviews.llvm.org/D61322





More information about the llvm-commits mailing list