[PATCH] D61358: [Sanitizer] Reland "Cleanup INTERCEPT_FUNCTION macro"

Julian Lettner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 30 17:54:59 PDT 2019


yln created this revision.
Herald added subscribers: llvm-commits, Sanitizers, kubamracek.
Herald added projects: Sanitizers, LLVM.

On Linux both version of the INTERCEPT_FUNCTION macro now return true
when interception was successful. Adapt and cleanup some usages.

Also note that `&(func) == &WRAP(func)` is a link-time property, but we
do a runtime check.

Tested on Linux and macOS.

Previous attempt reverted by: 5642c3feb03d020dc06a62e3dc54f3206a97a391 <https://reviews.llvm.org/rG5642c3feb03d020dc06a62e3dc54f3206a97a391>

This attempt to bring order to the interceptor macro goes the other
direction and aligns the Linux implementation with the way things are
done on Windows.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D61358

Files:
  compiler-rt/lib/asan/asan_interceptors.h
  compiler-rt/lib/interception/interception_linux.cc
  compiler-rt/lib/interception/interception_linux.h
  compiler-rt/lib/interception/tests/interception_linux_test.cc
  compiler-rt/lib/msan/msan_interceptors.cc
  compiler-rt/lib/tsan/rtl/tsan_interceptors.cc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61358.197493.patch
Type: text/x-patch
Size: 8458 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190501/0aeeb5ca/attachment.bin>


More information about the llvm-commits mailing list