[PATCH] D61354: [libFuzzer] Disable i386 on non-Linux platforms

Jonathan Metzman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 30 17:07:44 PDT 2019


metzman added reviewers: morehouse, rnk.
metzman added a comment.

Please take a look.
I could be less conservative here and only disable i386 on Windows but I frankly don't think the risk of breaking other platforms is worth the benefit (nothing).
This is intended to fix https://bugs.chromium.org/p/chromium/issues/detail?id=957971#c5 I've verified that the "fuzzer" target is no longer possible to build on x86 (as opposed to possible but failing as it was before).
It's also worth noting that this breakage is in part caused by libFuzzer building with MSVC (__builtin_clzll isn't supported by MSVC but _BitScanReverse64 is supported, but not on i386) instead of indirectly with clang.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61354/new/

https://reviews.llvm.org/D61354





More information about the llvm-commits mailing list