[PATCH] D61346: [CMake] Do not use libtool on Apple platforms when building LLVM with (full) LTO.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 30 15:56:03 PDT 2019


mehdi_amini added inline comments.


================
Comment at: llvm/CMakeLists.txt:55
+  string(TOUPPER "${LLVM_ENABLE_LTO}" uppercase_LLVM_ENABLE_LTO)
+  if(NOT uppercase_LLVM_ENABLE_LTO STREQUAL "FULL" OR CMAKE_AR_val)
+      # if CMAKE_LIBTOOL is not set, try and find it with xcrun or find_program
----------------
Why is this specific to full LTO? Isn't the same mechanism used for ThinLTO to build the symbol table for the archive?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61346/new/

https://reviews.llvm.org/D61346





More information about the llvm-commits mailing list