[PATCH] D61159: [SimplifyCFG] Run ReduceSwitchRange unconditionally, generalize
Shawn Landden via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 30 13:57:12 PDT 2019
shawnl marked an inline comment as done.
shawnl added inline comments.
================
Comment at: lib/Transforms/Utils/SimplifyCFG.cpp:5529
+ unsigned BestIndex = 0;
+ for (unsigned i = 1;i != Values.size();i++) {
+ if (Values[i] - Values[i-1] > BestDistance) {
----------------
lebedev.ri wrote:
> jmolloy wrote:
> > Please use capitals for induction variables, calculate the end value once, and use preincrement as per style guide:
> >
> > for (unsigned I = 1, E = Values.size(); I != E; ++I) {
> This wasn't done
Oh I switched to using E in most places and I will use it here. I also ran git-clang-format.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61159/new/
https://reviews.llvm.org/D61159
More information about the llvm-commits
mailing list