[PATCH] D61286: Skip functions with inallocas in argpromotion

Bob Haarman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 30 13:21:05 PDT 2019


inglorion added a comment.

Yeah, I kind of wanted to do the least intrusive thing that would fix the problem I observed and then think about the larger picture. But given that we're thinking about removing the inalloca attribute, the way I would like to do that is remove it in globalopt and then we can perform further optimizations (in globalopt and here) predicated on no inalloca being present. That takes care of half the FIXME for inalloca in globalopt, so after that it becomes really tempting to do follow-up with the other half and hoist the alloca to the entry block.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61286/new/

https://reviews.llvm.org/D61286





More information about the llvm-commits mailing list