[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In D59168#1484754 <https://reviews.llvm.org/D59168#1484754>, @phosek wrote:

> It's the `LIBCXX_ABI_VERSION` CMake option, see https://github.com/llvm/llvm-project/blob/master/libcxx/CMakeLists.txt#L121


Thanks.



================
Comment at: libunwind/CMakeLists.txt:190
 if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE)
-  set(DEFAULT_INSTALL_PREFIX lib${LLVM_LIBDIR_SUFFIX}/clang/${CLANG_VERSION}/${LLVM_DEFAULT_TARGET_TRIPLE}/)
-  set(LIBUNWIND_LIBRARY_DIR ${LLVM_LIBRARY_OUTPUT_INTDIR}/clang/${CLANG_VERSION}/${LLVM_DEFAULT_TARGET_TRIPLE}/lib${LIBUNWIND_LIBDIR_SUFFIX})
+  set(LIBUNWIND_LIBRARY_DIR ${LLVM_LIBRARY_OUTPUT_INTDIR}/${LLVM_DEFAULT_TARGET_TRIPLE}/c++)
+  set(LIBUNWIND_INSTALL_LIBRARY_DIR lib${LLVM_LIBDIR_SUFFIX}/${LLVM_DEFAULT_TARGET_TRIPLE}/c++)
----------------
phosek wrote:
> jdenny wrote:
> > I naively assumed libunwind would have its own directory so it could be selected independently.  Does this mean any library for C++ goes in c++?
> We could do that, but I'm not sure if it's worth doing without a clear use case? Do you know of any client that would want to consume libunwind independently of other C++ libraries? I'm aware of Rust but they build libunwind independently so there's no need for this.
I'm afraid I have no idea.  I'm not close enough to these libraries to be an adequate reviewer by myself.  Another reviewer should probably take a look at the new version of the patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59168/new/

https://reviews.llvm.org/D59168