[PATCH] D61116: [test-suite] MultiSource/Benchmarks/DOE-ProxyApps-C/RSBench: change *CMAKE* target name only

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

llvm_multisource has an option "PREFIX" that can be used to disambiguate target names. However, in my experience when using it collecting metrics does not work as reliable with this options.

Why not changing the name of rsbench downstream? Changing upstream to solve downstream conflicts seems to be the wrong direction.



================
Comment at: MultiSource/Benchmarks/DOE-ProxyApps-C/RSBench/CMakeLists.txt:4
 set(RUN_OPTIONS -s small -l 100000 -p 1000 -w 1000)
-llvm_multisource(rsbench)
+# WARNING: *please* keep the cmake target name as doe-rsbench.
+llvm_multisource(doe-rsbench)
----------------
[serious] Please add the reason why it has to have this name.


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61116/new/

https://reviews.llvm.org/D61116