[PATCH] D60831: [DebugInfo at O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 30 09:56:48 PDT 2019


hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

In D60831#1483817 <https://reviews.llvm.org/D60831#1483817>, @Orlando wrote:

> > My take-away from the discussion was this: It is desirable to map the instructions to something in the loop (e.g., not line 0), unless doing so will provide confusing information to the mapping that PGO uses to optimize the relevant branches. Am I correct in saying that this latter issue is of minimal concern in this case?
>
> As far as I see it you are correct. There should be negligible to no impact on PGO.


Sounds good. LGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60831/new/

https://reviews.llvm.org/D60831





More information about the llvm-commits mailing list