[PATCH] D60980: [libFuzzer] Replace -seed_corpus to better support fork mode on Win

[Kostya Serebryany via Phabricator via llvm-commits]

kcc accepted this revision.
kcc added a comment.
This revision is now accepted and ready to land.

LGTM with several nits.



================
Comment at: compiler-rt/lib/fuzzer/FuzzerDriver.cpp:771
+    std::string SeedInputs;
+    if (Flags.seed_inputs[0] == '@') {
+      // -seed_inputs=@seed_list_file.
----------------
plz make this if-else more compact (no {}, comments on the same line)


================
Comment at: compiler-rt/lib/fuzzer/FuzzerFlags.def:24
 FUZZER_FLAG_STRING(seed_inputs, "A comma-separated list of input files "
-  "to use as an additional seed corpus")
+  "of input files to use as an additional seed corpus. Alternatively, an \"@\" "
+  " followed by the name of a file containing the comma-seperated list.")
----------------
"of input files" repeated twice? 


================
Comment at: compiler-rt/test/fuzzer/seed_inputs.test:3
+
+USE-2: INFO: seed corpus: files: 2
+RUN: echo -n "%t-SimpleTest,%t-SimpleTest" > %t.seed-inputs
----------------
replace with CHECK: then remove all --check-prefix


================
Comment at: compiler-rt/test/fuzzer/seed_inputs.test:13
+RUN: %run %t-SimpleTest -runs=1 -seed_inputs=%t-SimpleTest,%t-SimpleTest,nonexistent-file, 2>&1 | FileCheck %s --check-prefix=USE-2
\ No newline at end of file

----------------
terminate the file with a newline


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60980/new/

https://reviews.llvm.org/D60980