[PATCH] D56772: [MIR] Add simple PRE pass to MachineCSE

[Anton Afanasyev via Phabricator via llvm-commits]

anton-afanasyev marked an inline comment as done.
anton-afanasyev added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineCSE.cpp:784
+    MachineInstr *MI = &*I;
+    ++I;
+
----------------
RKSimon wrote:
> anton-afanasyev wrote:
> > RKSimon wrote:
> > > Very minor - but why can't the ++I be moved inside the for-loop increment statement?
> > It can, I'm to fix it, thanks.
> This one too?
Hmm, looks like I've eventually fixed L506 -- the original loop inside `ProcessBlockCSE()` instead of `ProcessBlockPRE()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56772/new/

https://reviews.llvm.org/D56772