[PATCH] D61151: [SimpligyCFG] NFC, remove GCD that was only used for powers of two
Shawn Landden via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 30 07:00:27 PDT 2019
shawnl marked an inline comment as done.
shawnl added inline comments.
================
Comment at: lib/Transforms/Utils/SimplifyCFG.cpp:5563
+ for (auto &V : Values)
+ V = (int64_t)((uint64_t)V >> Shift);
----------------
jmolloy wrote:
> I'd recommend just switching to using APInt. That's what it's for after all - making things like this self-explaining.
I remove your signed interpretation in a later patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61151/new/
https://reviews.llvm.org/D61151
More information about the llvm-commits
mailing list