[PATCH] D61306: [NFC] Refactor visitIntrinsicCall so it doesn't return a const char*

[Clement Courbet via Phabricator via llvm-commits]

courbet added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:5494
 /// as a call to a named external function, return the name. Otherwise, lower it
 /// and return null.
+void SelectionDAGBuilder::visitIntrinsicCall(const CallInst &I,
----------------
Please update the comment.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7542
+
   if (I.countOperandBundlesOfType(LLVMContext::OB_deopt))
     LowerCallSiteWithDeoptBundle(&I, Callee, nullptr);
----------------
So this is not really an NFC as this is is no longer executed on `setjmp`, `longjmp`, and `clear_cache`.  Here ends my knowledge, let's find reviewers who can comment on whether this is OK or not :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61306/new/

https://reviews.llvm.org/D61306