[PATCH] D56772: [MIR] Add simple PRE pass to MachineCSE

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM - based on the improved codegen and the negligible effect on compile time.  Thanks.



================
Comment at: llvm/lib/CodeGen/MachineCSE.cpp:784
+    MachineInstr *MI = &*I;
+    ++I;
+
----------------
Very minor - but why can't the ++I be moved inside the for-loop increment statement?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56772/new/

https://reviews.llvm.org/D56772