[llvm] r359556 - [cmake] Fix error message on simulated VS version check
Russell Gallop via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 30 05:37:10 PDT 2019
Author: russell_gallop
Date: Tue Apr 30 05:37:10 2019
New Revision: 359556
URL: http://llvm.org/viewvc/llvm-project?rev=359556&view=rev
Log:
[cmake] Fix error message on simulated VS version check
For clang-cl self hosts in VS2015 environment this was reporting: "Host
Clang must have at least -fms-compatibility-version=19.00.24213.1, your
version is 9.0.0".
This check fires as CMake detects the simulated environment as _MSC_VER
1900, which is truncated. This makes it less than the required
19.00.24213.1.
Differential revision: https://reviews.llvm.org/D61188
Modified:
llvm/trunk/cmake/modules/CheckCompilerVersion.cmake
Modified: llvm/trunk/cmake/modules/CheckCompilerVersion.cmake
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/CheckCompilerVersion.cmake?rev=359556&r1=359555&r2=359556&view=diff
==============================================================================
--- llvm/trunk/cmake/modules/CheckCompilerVersion.cmake (original)
+++ llvm/trunk/cmake/modules/CheckCompilerVersion.cmake Tue Apr 30 05:37:10 2019
@@ -50,7 +50,7 @@ check_compiler_version("MSVC" "Visual St
if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
if (CMAKE_CXX_SIMULATE_ID MATCHES "MSVC")
if (CMAKE_CXX_SIMULATE_VERSION VERSION_LESS MSVC_MIN)
- message(FATAL_ERROR "Host Clang must have at least -fms-compatibility-version=${MSVC_MIN}, your version is ${CMAKE_CXX_COMPILER_VERSION}.")
+ message(FATAL_ERROR "Host Clang must have at least -fms-compatibility-version=${MSVC_MIN}, your version is ${CMAKE_CXX_SIMULATE_VERSION}.")
endif()
set(CLANG_CL 1)
elseif(NOT LLVM_ENABLE_LIBCXX)
More information about the llvm-commits
mailing list