[PATCH] D61298: [LLD] Emit dynamic relocations for references to script symbols in -pie links

[George Rimar via Phabricator via llvm-commits]

grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM too (with 2 nits).



================
Comment at: lld/test/ELF/linkerscript/symbol-pie.s:3
+## relocations for references to non-absolute script
+## symbols so that their values are correct at runtime.
+
----------------
We normally put `# REQUIRES:` line first in the test cases. Please put the comment before the `CHECK`.


================
Comment at: lld/test/ELF/linkerscript/symbol-pie.s:11
+
+# CHECK: Relocation section '.rela.dyn' at offset {{.*}} contains 1 entries:
+
----------------
I would perhaps check the relocation too. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61298/new/

https://reviews.llvm.org/D61298