[PATCH] D61116: [test-suite] MultiSource/Benchmarks/DOE-ProxyApps-C/RSBench: change *CMAKE* target name only
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 30 00:25:27 PDT 2019
lebedev.ri added a comment.
In D61116#1483599 <https://reviews.llvm.org/D61116#1483599>, @hfinkel wrote:
> While I'm sympathetic, we have a lot of benchmark names which are short and could conflict with other things.
> We have xsbench too.
Sure, yes. But handling conflicts as they appears isn't really an invalid strategy, either.
This *only* changes the cmake target name, not the binary name, so this should be virtually unnoticeable,
unless one directly cares about that cmake target name that is of course.
> Either we should solve this uniformly, or not at all.
Can you define the scope of `uniformly`? Every `[a-zA-Z][a-zA-Z0-9]bench`?
> You can always carry local patches for name conflicts with out-of-tree things.
I *could* but i'm trying to avoid that.
Repository:
rT test-suite
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61116/new/
https://reviews.llvm.org/D61116
More information about the llvm-commits
mailing list