[PATCH] D60131: [ELF] Change default output section type to SHT_PROGBITS

Mon Apr 29 20:02:37 PDT 2019

phosek added a comment.

In D60131#1483160 <https://reviews.llvm.org/D60131#1483160>, @andrewng wrote:

> In D60131#1483142 <https://reviews.llvm.org/D60131#1483142>, @phosek wrote:
>
> > D61197 <https://reviews.llvm.org/D61197> seems to have addressed the issue, D61186 <https://reviews.llvm.org/D61186> made no difference.
>
>
> Hopefully, I'll get an LGTM for D61197 <https://reviews.llvm.org/D61197> soon and will be able to land it. We're waiting on this fix too :). The default output section type of SHT_NOBITS was actually "hiding" a number of issues...

There's still no response on D61197 <https://reviews.llvm.org/D61197>, can we revert this change until the other one is approved and then reland it? I'd argue that in the current state it's actually worse than before.

Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60131/new/

https://reviews.llvm.org/D60131