[PATCH] D61089: [Reassociation] Place moved instructions after landing pads
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 29 15:46:06 PDT 2019
efriedma added inline comments.
================
Comment at: llvm/lib/Transforms/Scalar/Reassociate.cpp:874
+ // the landingpad.
+ while (isa<PHINode>(InsertPt) || isa<LandingPadInst>(InsertPt))
+ ++InsertPt;
----------------
Explicitly checking for LandingPad isn't sufficient on Windows. There are two issues: one, you need to use isEHPad() to check for all the relevant exception-handling instructions, and two, you can't insert a negate into a block with a catchswitch.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61089/new/
https://reviews.llvm.org/D61089
More information about the llvm-commits
mailing list