[llvm] r359493 - Fix string UAF in new FileCheck test

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 29 12:56:46 PDT 2019


Author: rnk
Date: Mon Apr 29 12:56:46 2019
New Revision: 359493

URL: http://llvm.org/viewvc/llvm-project?rev=359493&view=rev
Log:
Fix string UAF in new FileCheck test

Modified:
    llvm/trunk/unittests/Support/FileCheckTest.cpp

Modified: llvm/trunk/unittests/Support/FileCheckTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Support/FileCheckTest.cpp?rev=359493&r1=359492&r2=359493&view=diff
==============================================================================
--- llvm/trunk/unittests/Support/FileCheckTest.cpp (original)
+++ llvm/trunk/unittests/Support/FileCheckTest.cpp Mon Apr 29 12:56:46 2019
@@ -98,7 +98,7 @@ private:
 
 public:
   bool parseExpect(std::string &VarName, std::string &Trailer) {
-    StringRef NameTrailer = StringRef(VarName + Trailer);
+    std::string NameTrailer = VarName + Trailer;
     std::unique_ptr<MemoryBuffer> Buffer =
         MemoryBuffer::getMemBufferCopy(NameTrailer, "TestBuffer");
     StringRef NameTrailerRef = Buffer->getBuffer();




More information about the llvm-commits mailing list