[llvm] r359488 - [llvm-pdbutil] FunctionDumper::dump(PDBSymbolTypeFunctionArg) - fix null dereference warning

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 29 12:40:13 PDT 2019


Author: rksimon
Date: Mon Apr 29 12:40:12 2019
New Revision: 359488

URL: http://llvm.org/viewvc/llvm-project?rev=359488&view=rev
Log:
[llvm-pdbutil] FunctionDumper::dump(PDBSymbolTypeFunctionArg) - fix null dereference warning

Reported in https://www.viva64.com/en/b/0629/

Modified:
    llvm/trunk/tools/llvm-pdbutil/PrettyFunctionDumper.cpp

Modified: llvm/trunk/tools/llvm-pdbutil/PrettyFunctionDumper.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-pdbutil/PrettyFunctionDumper.cpp?rev=359488&r1=359487&r2=359488&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-pdbutil/PrettyFunctionDumper.cpp (original)
+++ llvm/trunk/tools/llvm-pdbutil/PrettyFunctionDumper.cpp Mon Apr 29 12:40:12 2019
@@ -228,9 +228,9 @@ void FunctionDumper::dump(const PDBSymbo
   uint32_t TypeId = Symbol.getTypeId();
   auto Type = Symbol.getSession().getSymbolById(TypeId);
   if (Type)
-    Printer << "<unknown-type>";
-  else
     Type->dump(*this);
+  else
+    Printer << "<unknown-type>";
 }
 
 void FunctionDumper::dump(const PDBSymbolTypeTypedef &Symbol) {




More information about the llvm-commits mailing list