[PATCH] D61254: [UpdateTestChecks] Allow Lbegin_func without a leading period

Mon Apr 29 12:18:54 PDT 2019

mstorsjo marked an inline comment as done.
mstorsjo added inline comments.

================
Comment at: utils/UpdateTestChecks/asm.py:17
 ASM_FUNCTION_X86_RE = re.compile(
-    r'^_?(?P<func>[^:]+):[ \t]*#+[ \t]*@(?P=func)\n(?:\s*.Lfunc_begin[^:\n]*:\n)?[^:]*?'
+    r'^_?(?P<func>[^:]+):[ \t]*#+[ \t]*@(?P=func)\n(?:\s*.?Lfunc_begin[^:\n]*:\n)?[^:]*?'
     r'(?P<body>^##?[ \t]+[^:]+:.*?)\s*'
----------------
rnk wrote:
> Should the `.` be escaped too? Right now I think it matches anything.
Yes, I believe so. I can amend it at the same time.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61254/new/

https://reviews.llvm.org/D61254