[llvm] r359479 - [X86] scaleShuffleMask - avoid potential signed overflow warning.
Simon Pilgrim via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 29 11:32:06 PDT 2019
Author: rksimon
Date: Mon Apr 29 11:32:06 2019
New Revision: 359479
URL: http://llvm.org/viewvc/llvm-project?rev=359479&view=rev
Log:
[X86] scaleShuffleMask - avoid potential signed overflow warning.
Use size_t assignment to prevent a bad explicit type conversion warning.
Given the typical size of shuffle masks this was never going to happen, but this at least stops the warning.
Reported in https://www.viva64.com/en/b/0629/
Modified:
llvm/trunk/lib/Target/X86/X86ISelLowering.h
Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.h?rev=359479&r1=359478&r2=359479&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.h (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.h Mon Apr 29 11:32:06 2019
@@ -1600,10 +1600,10 @@ namespace llvm {
void scaleShuffleMask(int Scale, ArrayRef<T> Mask,
SmallVectorImpl<T> &ScaledMask) {
assert(0 < Scale && "Unexpected scaling factor");
- int NumElts = Mask.size();
- ScaledMask.assign(static_cast<size_t>(NumElts * Scale), -1);
+ size_t NumElts = Mask.size();
+ ScaledMask.assign(NumElts * Scale, -1);
- for (int i = 0; i != NumElts; ++i) {
+ for (int i = 0; i != (int)NumElts; ++i) {
int M = Mask[i];
// Repeat sentinel values in every mask element.
More information about the llvm-commits
mailing list