[PATCH] D61268: [AddressSanitizer] [Windows] Fix HeapReAlloc and _recalloc bugs in asan_malloc_win.cc

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 29 11:19:39 PDT 2019


rnk added a comment.

Watch out for `compiler-rt/lib/sanitizer_common/scripts/check_lint.sh`, sometimes it disagrees with what clang-format does. It runs as part of `check-sanitizer` on Linux but not Windows. I have run into this accidentally numerous times. If you don't want to worry about that, consider using git-clang-format to avoid reformatting lines not affected by your patch.

Functionality seems good, thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61268/new/

https://reviews.llvm.org/D61268





More information about the llvm-commits mailing list